Added option to run startup scripts silently#1045
Merged
Merged
Conversation
kmvanbrunt
force-pushed
the
silent_start
branch
from
633086b to
38b5099
Compare
anselor
previously approved these changes
Jan 23, 2021
tleonhardt
previously approved these changes
Jan 23, 2021
tleonhardt
left a comment
tleonhardt
left a comment
Member
There was a problem hiding this comment.
Strongly recommend updating one of the examples which use startup_script to also use this new option to help with discoverability - basic.py would be a good candidate
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 22 22
Lines 4616 4619 +3
=======================================
+ Hits 4520 4523 +3
Misses 96 96
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Jan 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1010